-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add non-nix pre-commit rustfmt and clippy hooks #986
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my boring Arch (btw) 🚀
@cafkafk this is ready 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the merge update and instead use a rebase to get the branch up to date with main? Using merge clutters the commit log unnecessarily. Else looks good 👍
wait... don't those merge commits get squashed? EDIT: just looked through git history... wow wtf how does github not |
fix: correct nix pre-commit, update instructions chore: rename non-nix pre commit cfg and update docs to reflect
For those of us who don't use nix on a daily basis, it's nice to have the option of getting
rustfmt
+clippy
running before we commit.